Skip to content

Commit

Permalink
Added an explicit dependency on numpy 1 (#181)
Browse files Browse the repository at this point in the history
* Added an explicit dependency on numpy 1

* Fixed numpy version

* Fixed typo

* Drop nptyping
  • Loading branch information
openvmp authored Sep 3, 2024
1 parent ea6c5d1 commit 35b5c21
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 7 deletions.
1 change: 1 addition & 0 deletions partcad/requirements.txt
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
build123d>=0.5.0
cadquery>=2.4.0
numpy>=1.24.1,<2
ocp_tessellate
scipy>=1.11.1
pyyaml>=6.0.1
GitPython>=3.1.40
Expand Down
12 changes: 5 additions & 7 deletions partcad/src/partcad/runtime_python.py
Original file line number Diff line number Diff line change
Expand Up @@ -57,10 +57,10 @@ async def run(self, cmd, stdin="", cwd=None):
stdout = stdout.decode()
stderr = stderr.decode()

if stdout:
pc_logging.debug("Output of %s: %s" % (cmd, stdout))
if stderr:
pc_logging.debug("Error of %s: %s" % (cmd, stderr))
# if stdout:
# pc_logging.debug("Output of %s: %s" % (cmd, stdout))
# if stderr:
# pc_logging.debug("Error of %s: %s" % (cmd, stderr))

# TODO(clairbee): remove the below when a better troubleshooting mechanism is introduced
# f = open("/tmp/log", "w")
Expand All @@ -87,9 +87,7 @@ async def ensure(self, python_package):
with pc_logging.Action(
"PipInst", self.version, python_package
):
await self.run(
["-m", "pip", "install", python_package]
)
await self.run(["-m", "pip", "install", python_package])
pathlib.Path(guard_path).touch()

async def prepare_for_package(self, project):
Expand Down

0 comments on commit 35b5c21

Please sign in to comment.