-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 0.2.0 connection migration script #731
Closed
TimoGlastra
wants to merge
63
commits into
openwallet-foundation:feat/out-of-band
from
TimoGlastra:feat/020-connection-migration
Closed
feat: 0.2.0 connection migration script #731
TimoGlastra
wants to merge
63
commits into
openwallet-foundation:feat/out-of-band
from
TimoGlastra:feat/020-connection-migration
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jakub Koci <jakub.koci@gmail.com>
Signed-off-by: Jakub Koci <jakub.koci@gmail.com>
Signed-off-by: Jakub Koci <jakub.koci@gmail.com>
Signed-off-by: Jakub Koci <jakub.koci@gmail.com>
…ssage receiver Signed-off-by: Jakub Koci <jakub.koci@gmail.com>
Signed-off-by: Jakub Koci <jakub.koci@gmail.com>
Signed-off-by: Jakub Koci <jakub.koci@gmail.com>
Signed-off-by: Jakub Koci <jakub.koci@gmail.com>
Signed-off-by: Jakub Koci <jakub.koci@gmail.com>
Signed-off-by: Jakub Koci <jakub.koci@gmail.com>
Signed-off-by: Jakub Koci <jakub.koci@gmail.com>
Signed-off-by: Jakub Koci <jakub.koci@gmail.com>
Signed-off-by: Jakub Koci <jakub.koci@gmail.com>
Signed-off-by: Jakub Koci <jakub.koci@gmail.com>
Signed-off-by: Jakub Koci <jakub.koci@gmail.com>
Signed-off-by: Jakub Koci <jakub.koci@gmail.com>
Signed-off-by: Jakub Koci <jakub.koci@gmail.com>
Signed-off-by: Jakub Koci <jakub.koci@gmail.com>
Signed-off-by: Jakub Koci <jakub.koci@gmail.com>
Signed-off-by: Jakub Koci <jakub.koci@gmail.com>
Signed-off-by: Jakub Koci <jakub.koci@gmail.com>
Signed-off-by: Jakub Koci <jakub.koci@gmail.com>
Signed-off-by: Jakub Koci <jakub.koci@gmail.com>
Signed-off-by: Jakub Koci <jakub.koci@gmail.com>
Signed-off-by: Jakub Koci <jakub.koci@gmail.com>
Signed-off-by: Jakub Koci <jakub.koci@gmail.com>
Signed-off-by: Jakub Koci <jakub.koci@gmail.com>
Signed-off-by: Jakub Koci <jakub.koci@gmail.com>
Signed-off-by: Jakub Koci <jakub.koci@gmail.com>
Signed-off-by: Jakub Koci <jakub.koci@gmail.com>
Signed-off-by: Jakub Koci <jakub.koci@gmail.com>
Signed-off-by: Jakub Koci <jakub.koci@gmail.com>
Signed-off-by: Jakub Koci <jakub.koci@gmail.com>
* Create a new connection instead of reusing an existing one * Add did doc signature * Add state machine and state updates * Add did exchange handlers * Add did exchange protocol to connections module * Make it work with peer dids * Revert changes in old authentication and public key tranformations * Allow to set hanshake protocol when creating oob message * Extract did exchange state machine * Add generic way to get auth public key from diddoc * Add did exchange problem report * Iterate over all service endpoints * Allow only numalgo 1 and peer dids inside message * Send stored variant of did document in message * Update accepted didcomm profiles * Add routing keys as verification methods and use publicBase58 keys in service * Add oob test with mediation Signed-off-by: Jakub Koci <jakub.koci@gmail.com>
* Add oob record and make it work with did exchange * Make oob work also with connection protocol * Add auto accept connection flag to create oob config * Save oob record when receiving message * Separate accept invitation according to handshake protocol * Use oob record for connections protocol initiated by oob message * Add oob service to access repository * Add oob record state update * Iterate over all endpoints in routing * Use uniqe array of keys from all services Signed-off-by: Jakub Koci <jakub.koci@gmail.com>
…ion#676) * Separate OOB invitation and OOB message handling * Replace create connection method with oob * Update oob API with default values and remove old invitation methods * Rename oob method to use invitation instead of message * Split making a mediation connection and provisioning mediation * Expose method to create legacy connection invitation Signed-off-by: Jakub Koci <jakub.koci@gmail.com>
…oundation#680) * Refactor assert state, role and rename methods * Narrow oob state checks Signed-off-by: Jakub Koci <jakub.koci@gmail.com>
…let-foundation#687) * Remove verkey and theirKey from connection record * Remove did docs from connection record * Reuse oob keys for created connection * Remove check for peer did and rename sender did doc to our did doc * Assume one did record per recipient or sender key * Resolve did doc instead of fetch from repository * Take only auth keys as their verkeys when storing did record Signed-off-by: Jakub Koci <jakub.koci@gmail.com>
…undation#698) * Extract creation of did doc from services * Create peer did from service and store it as invitation did Signed-off-by: Jakub Koci <jakub.koci@gmail.com>
It fixes changes after rebase Signed-off-by: Jakub Koci <jakub.koci@gmail.com>
…ndation#700) * Use instance of Key in message context Signed-off-by: Jakub Koci <jakub.koci@gmail.com>
Signed-off-by: Timo Glastra <timo@animo.id>
Signed-off-by: Timo Glastra <timo@animo.id>
Signed-off-by: Timo Glastra <timo@animo.id>
Signed-off-by: Timo Glastra <timo@animo.id>
Signed-off-by: Timo Glastra <timo@animo.id>
Signed-off-by: Timo Glastra <timo@animo.id>
Signed-off-by: Timo Glastra <timo@animo.id>
Codecov Report
@@ Coverage Diff @@
## feat/out-of-band #731 +/- ##
====================================================
+ Coverage 87.19% 87.34% +0.14%
====================================================
Files 388 390 +2
Lines 8850 8954 +104
Branches 1518 1533 +15
====================================================
+ Hits 7717 7821 +104
Misses 1072 1072
Partials 61 61
Continue to review full report at Codecov.
|
This was referenced Apr 30, 2022
Signed-off-by: Timo Glastra <timo@animo.id>
33 tasks
jakubkoci
force-pushed
the
feat/out-of-band
branch
from
May 12, 2022 14:18
aa65719
to
8c438aa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds migration script for the breaking changes introduced in 0.2.0 with the addition of out of band protocol and
did:peer
dids.This should be merged after #717 is merged ( I will update the target to main then ), as it depends on those Changes. Keeping it as separate PR to not make the PR bigger.
I think there's some issues with the transformation of the invitations and did documents that we should address, but that can be address separately. This PR just leans on the methods for transformation already provided in PR #717
There's one FIXME left because I wasn't 100% sure on how it worked. @jakubkoci maybe you can help me answer. When creating an oob record that is reusable, is it correct that all connections will have the same oob id? If that's true I need to make some small tweaks to the script.