-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Peer DID Interop tests - Peer DID Transition #760
Peer DID Interop tests - Peer DID Transition #760
Conversation
Signed-off-by: Sheldon Regular <sheldon.regular@gmail.com>
Signed-off-by: Sheldon Regular <sheldon.regular@gmail.com>
Signed-off-by: Sheldon Regular <sheldon.regular@gmail.com>
Signed-off-by: Sheldon Regular <sheldon.regular@gmail.com>
…esh/aries-agent-test-harness into feature-peer-did-transition
Signed-off-by: Sheldon Regular <sheldon.regular@gmail.com>
This PR is ready for review and merge. We may have some help on the AFJ side so it would be good if these enhancements were in main. These Qualified DID Tests will run in the regular interop pipeline test execution cycle for ACA-py. It will run in the full acapy runset. It will not run for any other runset until the backchannels have be brought up to scope for these tests. Though these tests work with ACA-Py, we expect some of the test specification like the start parameters, etc to change to be more generalized across frameworks once we start working with AFJ and other frameworks in this test context. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
| did:peer:1 | {"wallet-type":"askar-anoncreds", "flags":["emit-did-peer-1"]} | {"wallet-type":"askar-anoncreds", "flags":["emit-did-peer-3"]} | | ||
| did:peer:2 | {"wallet-type":"askar-anoncreds", "flags":["emit-did-peer-2"]} | {"wallet-type":"askar-anoncreds", "flags":["emit-did-peer-4"]} | | ||
| did:peer:3 | {"wallet-type":"askar-anoncreds", "flags":["emit-did-peer-3"]} | {"wallet-type":"askar-anoncreds", "flags":["emit-did-peer-1"]} | | ||
| did:peer:4 | {"wallet-type":"askar-anoncreds", "flags":["emit-did-peer-4"]} | {"wallet-type":"askar-anoncreds", "flags":["emit-did-peer-2"]} | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, comments: I'm not sure it makes sense for us to include tests for did:peer:3. Also, ACA-Py has not implemented an emit-did-peer-1
mode.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added them in for when they are implemented these tests should then automatically pass. However, if we prefer, we can just comment them out until or if we support those modes.
I like a test first approach, where we have failing tests then the software catches up to the tests to make them pass. I can understand that we may not want that here, showing a higher fail rate for unimplemented features.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@swcurran Would you prefer currently unsupported DID Peer Methods to be commented out or leave them failing? I'm inclined to think you would want them commented out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are unlikely to implement support for emitting a did:peer:1 or 3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will any other Aries Framework implement those? The RFC mentions them so that is why I put them in.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AFJ implements 1 but it's actually not possible to exchange just did:peer:3s. You emit 2 and then derive a 3.
…rness into feature-peer-did-transition
Signed-off-by: Sheldon Regular <sheldon.regular@gmail.com>
The last commit here comments out the DID Peer Methods that ACA-Py doesn't support. Will add them back if and when we support them or another Aries framework does. |
Awesome work! Nice! |
This PR aims to partially complete #752. This is a draft PR until all ACA-Py tasks are completed below. AFJ tasks and other backchannel updates will be broken out into separate tickets if a ticket doesn't exist for it yet.
Given "n" agents
step contains startup args.--emit-peer-did-#
AFJ Backchannel Updates
VCX Backchannel Updates
Findy Backchannel Updates?
AFGO Backchannel UpdatesApply the modifications above to the AFGO Backchannel