-
-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix] Allow variables in mac address patterns in schema.py #239
base: master
Are you sure you want to change the base?
Conversation
tested as such:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you contributing @lpalgarvio! I have left some suggestions below which will improve this PR.
Cool, ill try these and update as soon as possible :) |
Sorry for the delay! A bit overloaded with OpenWrt projects and other things :) |
Also maybe i should rename the commit to add "[fix]" to unbreak the CI checks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for following up @lpalgarvio! I have tested your patch with openwisp-controller and these changes work as expected.
I have asked for one more improvement below. After that we should be able to merge this. Let us know if you'll be able to fix it.
Also maybe i should rename the commit to add "[fix]" to unbreak the CI checks
@lpalgarvio you are correct. The QA checks of OpenWISP requires the commit messages in a specific format. Please read the contribution guidelines. Don't worry about squashing the commits, we'll handle that when we merge the PR.
fixed PR title, commit title and description, and because was already rebasing anyways to fix titles, squashed all commits |
…enwisp#238) - Adds BLANK and VAR patterns - Patches MAC patterns - Removes usage of maxLength and minLength in mac and bssid properties Co-authored-by: Gagan Deep <the.one.above.all.titan@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for contributing @lpalgarvio! LGTM 👍🏼
Deferring merge to @nemesisdesign 😄
Closes #238