Refactored base-email-view #358
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nemesifier
requested changes
Sep 29, 2023
There was a problem hiding this comment.
@MihirKohli please check the details of the build / QA check failures.
openwisp_users/api/views.py
Outdated
| user.first().is_staff is True | ||
| and not qs.filter(pk=self.request.user.id).exists() | ||
| user.first().is_staff is True | ||
| and not qs.filter(pk=self.request.user.id).exists() |
openwisp_users/api/views.py
Outdated
| def get_serializer_context(self): | ||
| if getattr(self, 'swagger_fake_view', False): | ||
| # To get rid of assertion error raised in | ||
| # the dev server, and for schema generation |
There was a problem hiding this comment.
do not remove these comments please
MihirKohli
force-pushed
the
refactor-base-email-view
branch
from
5eb5aad
to
793c1e6
Compare
MihirKohli
force-pushed
the
refactor-base-email-view
branch
from
793c1e6
to
44be783
Compare
|
made changes do check it |
nemesifier
requested changes
Oct 2, 2023
| @@ -198,7 +199,7 @@ def update(self, request, *args, **kwargs): | |||
| ) | |||
|
|
|||
|
|
|||
| class BaseEmailView(ProtectedAPIMixin, GenericAPIView): | |||
| class BaseEmailView(ProtectedAPIMixin, FilterByParent, GenericAPIView): | |||
There was a problem hiding this comment.
Yeah ok, we're inheriting from this FilterByParent now but there's some code here in BaseEmailView which is now redundant and has to be removed, which is not being done in this patch, so the goal of the issue is not being reached yet.
|
@MihirKohli I am closing this PR due to inactivity. Feel free to re-open the PR if you want to continue with the requested changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved #354