config: allow to modify operations timeout #727
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #727 +/- ##
==========================================
+ Coverage 87.46% 87.67% +0.21%
==========================================
Files 15 16 +1
Lines 973 990 +17
==========================================
+ Hits 851 868 +17
Misses 122 122 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
aparcar
reviewed
Feb 5, 2024
asu/janitor.py
Outdated
| import importlib.util | ||
|
|
||
| for config_file in ["/etc/asu/config.py", "misc/config.py"]: | ||
| if os.path.exists(config_file): |
There was a problem hiding this comment.
Please use pathlib instead of os.path
a-gave
force-pushed
the
feat/allow-to-modify-operations-timeout
branch
from
084b20d
to
8210d6c
Compare
|
What is the status of this PR? |
|
This referred to an older version of the code, and now seems unnecessary. I'm closing it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces an additional option to modify the operations timeout (currently defaulted to '10m')
The reason is to allow an installation of asu even on a machine that has low bandwidth availability, or a fair amount of latency.
Under these conditions asu may work fine, however the installation process may timeout during the profiles.json update process (unless the amount of available branches/releases is reduced)
In addition, even a single build may timeout if more than 10 minutes are required between downloading the imagebuilder corresponding to a request and compiling it.