luci-mod-network: add PXE Boot options to TFTP/PXE tab under DHCP & DNS #5304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
deleted |
feckert
changed the title
feckert
requested changes
Aug 30, 2021
modules/luci-mod-network/htdocs/luci-static/resources/view/network/dhcp.js
Outdated
Show resolved
Hide resolved
modules/luci-mod-network/htdocs/luci-static/resources/view/network/dhcp.js
Outdated
Show resolved
Hide resolved
modules/luci-mod-network/htdocs/luci-static/resources/view/network/dhcp.js
Outdated
Show resolved
Hide resolved
|
OK done. Should I make a separate PR for 21.02? |
|
@systemcrash |
|
Please don't add yet another tab. I would prefer to merge tftp and pxe into one as they're closely related and tftp currently is mostly empty. |
|
With some extra hinting for TFTP as at https://openwrt.org/docs/guide-user/base-system/dhcp#common_options
|
jow-
reviewed
Aug 31, 2021
modules/luci-mod-network/htdocs/luci-static/resources/view/network/dhcp.js
Outdated
Show resolved
Hide resolved
systemcrash
changed the title
|
OK |
|
Anything more from my side required? |
feckert
reviewed
Sep 7, 2021
modules/luci-mod-network/htdocs/luci-static/resources/view/network/dhcp.js
Show resolved
Hide resolved
modules/luci-mod-network/htdocs/luci-static/resources/view/network/dhcp.js
Outdated
Show resolved
Hide resolved
modules/luci-mod-network/htdocs/luci-static/resources/view/network/dhcp.js
Outdated
Show resolved
Hide resolved
modules/luci-mod-network/htdocs/luci-static/resources/view/network/dhcp.js
Outdated
Show resolved
Hide resolved
manages 'boot' entries in /etc/config/dhcp Signed-off-by: Paul Dee <systemcrash@users.noreply.github.com>
feckert
reviewed
Sep 27, 2021
|
Moved it closer to its usage. Should it need to return to |
jow-
requested changes
Sep 30, 2021
modules/luci-mod-network/htdocs/luci-static/resources/view/network/dhcp.js
Outdated
Show resolved
Hide resolved
modules/luci-mod-network/htdocs/luci-static/resources/view/network/dhcp.js
Outdated
Show resolved
Hide resolved
modules/luci-mod-network/htdocs/luci-static/resources/view/network/dhcp.js
Outdated
Show resolved
Hide resolved
modules/luci-mod-network/htdocs/luci-static/resources/view/network/dhcp.js
Outdated
Show resolved
Hide resolved
|
I split the static lease stuff into a separate PR #5401 |
|
ping - according to review this is ready. |
|
ping - seems ready |
|
Merged via 3165d5e - thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
manages 'boot' entries in /etc/config/dhcp
Should go into master and 21.02.
Tested on 21.02-rc4
I think it can also go into 19.07
If I'm not mistaken, I believe this resolves issue #502
See: https://openwrt.org/docs/guide-user/base-system/dhcp#booting_options