-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
luci-app-adguardhome: Add new app #5853
Open
cricalix
wants to merge
7
commits into
openwrt:master
Choose a base branch
from
cricalix:luci-app-adguardhome
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Commits on Jun 27, 2022
-
luci-app-adguardhome: Add new app
There is no integration into the web UI for AdGuard Home. This PR adds * A Lua script for rpcd to interface with the AGH REST API * ACL controls allowing JS code to call rpcd, uci, logread * Menu entries to put AdGuard Home under Services * Three UIs - status, logs, config The Lua script supports three API calls: * get_status - maps to /control/status in the AGH REST API * get_statistics - maps to /control/stats in the AGH REST API * get_config - converts /etc/adguardhome.yaml to JSON Authentication details must be provided by the user, as the password in the YAML file is encrypted. This results in the AGH password being stored cleartext in /etc/config/adguardhome. The Lua script will log if it encounters an error, in an effort to make it easier to debug. These logs are visible in the Logs UI of the application. I could not find any unit testing for things like the UI or the Lua code, so the only testing done was by hand. The credentials were removed from the config, and both the ubus call and the web UI render the failure to acquire the credentials. Incorrect credentials were supplied, and the UI was verified as showing a RPC error message. ACLs were checked by removing luci-compat.json (which wildcard allows saving/reading), and ensuring that the UI could read and save the config. Package was built and tested with ``` make package/luci-app-adguardhome/compile -j20 scp bin/packages/i386_pentium4/cricalixluci/luci-app-adguardhome_unknown_all.ipk root@192.168.0.1: ssh root@192.168.0.1 opkg remove luci-app-adguardhome && opkg install luci-app-adguardhome_unknown_all.ipk && rm luci-app-adguardhome_unknown_all.ipk ``` and then browsing the UI to make sure the deployment was clean and behaved as expected. Signed-off-by: Duncan Hill <openwrt-dev@cricalix.net>
Duncan Hill committedJun 27, 2022 Configuration menu - View commit details
-
Copy full SHA for 3253c26 - Browse repository at this point
Copy the full SHA 3253c26View commit details
Commits on Jun 16, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 913cb4f - Browse repository at this point
Copy the full SHA 913cb4fView commit details
Commits on Aug 5, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 0efa0b3 - Browse repository at this point
Copy the full SHA 0efa0b3View commit details -
Configuration menu - View commit details
-
Copy full SHA for f6f18a3 - Browse repository at this point
Copy the full SHA f6f18a3View commit details
Commits on Jan 6, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 2d6502c - Browse repository at this point
Copy the full SHA 2d6502cView commit details -
Rebase on recent pull, update README, handle new AGH config file, tes…
…t on 23.05, format code
Configuration menu - View commit details
-
Copy full SHA for 04effa4 - Browse repository at this point
Copy the full SHA 04effa4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 903e9ad - Browse repository at this point
Copy the full SHA 903e9adView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.