-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
luci-mod-network: add support for creating cname records #6335
Conversation
@hnyman @jow- @Zeranoe @feckert hey can someone take a look on this , this is very useful when you want to rewrite/shadow public DNS . from DNSMASQ man pages :
|
@@ -694,6 +695,27 @@ return view.extend({ | |||
so.datatype = 'range(0,65535)'; | |||
so.placeholder = '0'; | |||
|
|||
o = s.taboption('cnamehosts', form.SectionValue, '__cname__', form.TableSection, 'cname', null, | |||
('Set an alias for a hostname.')); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't that be like so?:
_('Set an alias for a hostname.'));
Sorry, yeah, I think so. just fixed it! |
This commit adds a tab that allows creating CNAME records Signed-off-by: Santiago Kozak <santikzk1406@gmail.com>
I messed up in a horrendous way but I think this is good now (unless the test build fails). Sorry for all the mess |
Just for my own edification, how does one push zero commits? 🤔
|
I did: found it on https://stackoverflow.com/questions/448919/how-can-i-remove-a-commit-on-github in the middle of my desperation lol |
Oh, now I know 😁
|
I used the MX and SRV tabs as templates to create a new tab where users can create cname records in dnsmasq, using the cname and target options.