luci-app-babeld: migrate to JavaScript-based implementation #6479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jow-
reviewed
Jul 25, 2023
applications/luci-app-babeld/htdocs/luci-static/resources/view/babeld/babeld-view.js
Outdated
Show resolved
Hide resolved
applications/luci-app-babeld/htdocs/luci-static/resources/babeld.js
Outdated
Show resolved
Hide resolved
applications/luci-app-babeld/htdocs/luci-static/resources/babeld.js
Outdated
Show resolved
Hide resolved
| for (var prefix in data[protocol]) { | ||
| var prefixRow = document.createElement('tr'); | ||
| prefixRow.setAttribute('class', 'tr'); | ||
| var prefixContent = '<td class="td" data-title="xroutes_' + protocol + '_prefix">' + prefix + '</td>\ |
There was a problem hiding this comment.
I fixed all the issues and also tested it.
Signed-off-by: Ayushman Tripathi <ayushmantripathi7724@gmail.com> luci-app-babeld: migrate to js fix makefile Signed-off-by: Ayushman Tripathi <ayushmantripathi7724@gmail.com> luci-app-babeld: migrate to js luci-app-babeld: migrate to js fix app name Signed-off-by: Ayushman Tripathi <ayushmantripathi7724@gmail.com> luci-app-babeld: migrate to js luci-app-babeld: migrate to js Signed-off-by: Ayushman Tripathi <ayushmantripathi7724@gmail.com> luci-app-babeld: migrate to js
Ayushmanwebdeveloper
force-pushed
the
luci-app-babeld-mig
branch
from
90d78cb
to
1325edf
Compare
|
@jow- this migrated app looks good to me |
|
Merged via 0c3f396 - thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! I've completed the migration of luci-app-babeld to JavaScript. All the features are functioning just like they did in the old Lua app.