Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

luci-mod-status: add support for the 6g band #6498

Merged
merged 3 commits into from
Sep 18, 2023
Merged

Conversation

dhewg
Copy link
Contributor

@dhewg dhewg commented Aug 4, 2023

Currently, results from the 2.4 and 6 ghz bands get mixed together, because internally the channel number is used for some checks.

This adds some checks to prevent that, and then adds a new 6g band tab.

This works on my end, but my AP is the only 6g one nearby, so I don't have others in my scan results. Can someone test that please?

@mj22226
Copy link

mj22226 commented Aug 5, 2023

@dhewg I tested, scan works, 6 ghz band is less crowded.

Screenshot_20230805

@dhewg
Copy link
Contributor Author

dhewg commented Aug 6, 2023

Nice, thanks!
The channel width looks wrong though, could you please run ubus call iwinfo scan '{"device":"radioX"}' (where X=your 6g radio), fish out the 6g nets and paste them here?

@dhewg
Copy link
Contributor Author

dhewg commented Sep 13, 2023

Well, maybe those widths are okay. At least my local 80mhz wide network shows up correctly.
This is a nice improvement, so let's merge and fix anything up if issues pop up?

@Ansuel
Copy link
Member

Ansuel commented Sep 18, 2023

@dhewg we should think of a solution for those channel number... Any idea?

maybe reduce the text size? Or write them on 2 different lines with an y offset?

@dhewg
Copy link
Contributor Author

dhewg commented Sep 18, 2023

The shot above may be an extreme example. It depends on the country code and the available channels. It looks like this for me:
6g

@Ansuel
Copy link
Member

Ansuel commented Sep 18, 2023

@dhewg mhhh ok but we also need to handle that case... I think a 2 line implementation is the simplest one and would solve the thing... and maybe guard it and enable this only when then chan number is > of a specific value?

I can do some test if you don't have time with handling this

@dhewg
Copy link
Contributor Author

dhewg commented Sep 18, 2023

That would be nice, js isn't my strong suit...

@Ansuel
Copy link
Member

Ansuel commented Sep 18, 2023

@mj22226 can you create an issue about this adding your image and tagging me so we can track this and I won't forget to improve this?

@Ansuel
Copy link
Member

Ansuel commented Sep 18, 2023

@dhewg nit last commit can you improve the commit description? Something like "Enable support for 6GHz band now that code supports it"

iwinfo already provides the band information with every channel, so just
use that instead.

Signed-off-by: Andre Heider <a.heider@gmail.com>
This prevents adding entries to mismatching bands when a channel
number exists on more than one band.

Signed-off-by: Andre Heider <a.heider@gmail.com>
Enable support for the 6GHz band now that the code supports it. For that it
just needs to be added to the "bands" object.

Signed-off-by: Andre Heider <a.heider@gmail.com>
@Ansuel Ansuel merged commit 318ef4c into openwrt:master Sep 18, 2023
2 checks passed
@dhewg dhewg deleted the status6g branch September 18, 2023 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants