Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

luci-mod-network: Adjust DHCP/DNS tab order #6502

Merged
merged 1 commit into from
Aug 5, 2023
Merged

Conversation

hnyman
Copy link
Contributor

@hnyman hnyman commented Aug 5, 2023

Adjust the order of tabs in the DNS/DHCP page.
Based on estimated importance of tabs

  • move common (old) tabs to be earlier
  • move the less frequently used (new) tabs later

Before:
image

New:
image

@jow-
I actually think that we might prefer to reorganise/group some tabs e.g the new DNS fields (MX, CNAME, SRV) to be subtabs. Possible?

Adjust the order of tabs in the DNS/DHCP page.
Based on estimated importance of tabs
* move common (old) tabs to be earlier
* move the less frequently used (new) tabs later

Signed-off-by: Hannu Nyman <hannu.nyman@iki.fi>
@systemcrash
Copy link
Contributor

Call me human but... Alphabetical order would be easiest and just plain practical. I never really know the exact name of what I'm looking for anyway, so I just go spatially and find what I'm looking for. So order isn't so important.

But do NOT bury tabs within tabs. More steps to reach destination. Ideally max 3 clicks to destination.

@jow-
Copy link
Contributor

jow- commented Aug 5, 2023

It's far too many tabs, also some really fringe use cases are overrepresented by having their own tab, like MX or SRV records. MX, SRV, CNAME and Hostnames (which is essentially A/AAAA) should be combined into one common DNS tab

@jow- jow- merged commit 85f8988 into openwrt:master Aug 5, 2023
2 checks passed
@jow-
Copy link
Contributor

jow- commented Aug 5, 2023

Merged as an interim solution, thanks!

@systemcrash
Copy link
Contributor

systemcrash commented Aug 6, 2023 via email

@hnyman hnyman deleted the dhcp-tabs branch August 6, 2023 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants