Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

luci-app-babeld: use an array for routing lists #7253

Merged
merged 1 commit into from
Sep 8, 2024
Merged

luci-app-babeld: use an array for routing lists #7253

merged 1 commit into from
Sep 8, 2024

Conversation

stargieg
Copy link
Contributor

  • This PR is not from my main or master branch 💩, but a separate branch ✅
  • Each commit has a valid ✒️ Signed-off-by: <my@email.address> row (via git commit --signoff)
  • Each commit and PR title has a valid 📝 <package name>: title first line subject for packages
  • Incremented 🆙 any PKG_VERSION in the Makefile
  • Tested on: ar71xx, ath79, x86_64, openwrt 19.07.10 23.05.4, Firefox ✅
  • ( Preferred ) Mention: vincent@systemli.org
  • ( Preferred ) Screenshot or mp4 of changes:
  • ( Optional ) Closes: luci-app-babeld: Hello-Reach is represented as a decimal number. #6342
  • ( Optional ) Depends on: babeld: use an array for routing lists routing#1078
  • Description: Use an array for routing lists. Use underscore in key name for libubox/jshn.sh compat. Change format specifiers for bool and decimal

@stargieg
luci-app-babeld: use an array for routing lists
129c9c5 
use underscore in key name for libubox/jshn.sh compat
change format specifiers for bool and decimal

Fix: openwrt/issues/6342
Fix: openwrt/routing/issues/966
Depends: faec308d95c99747b1efb09a72e499b4e3647b83

Signed-off-by: Patrick Grimm <patrick@lunatiki.de>
@stokito
Copy link
Contributor

stokito commented Sep 1, 2024

@PolynomialDivision please review

@PolynomialDivision
Copy link
Member

Thanks a lot!

@PolynomialDivision PolynomialDivision merged commit 0cdcd8c into openwrt:master Sep 8, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stokito stokito stokito approved these changes

@systemcrash systemcrash systemcrash approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

luci-app-babeld: Hello-Reach is represented as a decimal number.
4 participants
@stargieg @stokito @PolynomialDivision @systemcrash