Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

luci-proto-modemmanager: add initial EPS bearer support #7331

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

robimarko
Copy link

@robimarko robimarko commented Oct 17, 2024

  • This PR is not from my main or master branch 💩, but a separate branch ✅
  • Each commit has a valid ✒️ Signed-off-by: <my@email.address> row (via git commit --signoff)
  • Each commit and PR title has a valid 📝 <package name>: title first line subject for packages
  • Tested on: (qualcommax/ipq60xx, main, Chrome) ✅
  • Description: (describe the changes proposed in this PR)

ModemManager protocol has supported setting initial EPS bearer since package commit [1], so lets expose the same support via LuCI as well.

[1] openwrt/packages@af12147

Copy link
Contributor

@systemcrash systemcrash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to unburden i18n people. Shorter strings and put <br/> outside of them.

ModemManager protocol has supported setting initial EPS bearer since
package commit [1], so lets expose the same support via LuCI as well.

[1] openwrt/packages@af12147

Signed-off-by: Damir Samardzic <damir.samardzic@sartura.hr>
Signed-off-by: Robert Marko <robert.marko@sartura.hr>
@systemcrash
Copy link
Contributor

@feckert any comments?

@feckert feckert merged commit 24bbea6 into openwrt:master Oct 21, 2024
5 checks passed
@feckert
Copy link
Member

feckert commented Oct 21, 2024

Thanks merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants