Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

luci-app-example: Fix typo in README.md /s/id/is/ #7333

Closed
wants to merge 1 commit into from

Conversation

cpswan
Copy link

@cpswan cpswan commented Oct 18, 2024

  • This PR is not from my main or master branch πŸ’©, but a separate branch βœ…
  • Each commit has a valid βœ’οΈ Signed-off-by: <my@email.address> row (via git commit --signoff)
  • Each commit and PR title has a valid πŸ“ <package name>: title first line subject for packages
  • Incremented πŸ†™ any PKG_VERSION in the Makefile NA
  • Tested on: (architecture, openwrt version, browser) βœ… NA
  • ( Preferred ) Mention: @ the original code author for feedback @stokito
  • ( Preferred ) Screenshot or mp4 of changes:
  • ( Optional ) Closes: e.g. openwrt/luci#issue-number
  • ( Optional ) Depends on: e.g. openwrt/packages#pr-number in sister repo
  • Description: Fix a minor typo I spotted whilst learning from the example application.

@cpswan
Copy link
Author

cpswan commented Oct 18, 2024

I see that Test Formalities is failing with:

: Signed-off-by is missing or doesn't match author (should be 'Signed-off-by: Chris Swan <478926+cpswan@users.noreply.github.com>')
: Real email address policy: please configure GitHub email (<478926+cpswan@users.noreply.github.com>) to a real one

But that seems at odds with the statement in the PR template:

MAY:
- your S.O.B. *may* be a nickname

So I'm hoping that I don't have to reconfigure my GitHub profile setting just to keep the bot happy.

@stokito
Copy link
Contributor

stokito commented Oct 18, 2024

Signed-off-by: Chris Swan <478926+cpswan@users.noreply.github.com>
@cpswan
Copy link
Author

cpswan commented Oct 18, 2024

Thanks @stokito I've amended the commit to my usual GitHub email. I think the check will still fail, but I hope that's what you were asking for.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants