nodogsplash: update to version 5.0.2 #1023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwarning
force-pushed
the
nds
branch
2 times, most recently
from
be3c463
to
8ebb557
Compare
Fix a buffer overflow in case the query string is too long. Signed-off-by: Moritz Warning <moritzwarning@web.de>
mwarning
changed the title
BKPepe
reviewed
Oct 10, 2023
| @@ -40,6 +40,7 @@ define Package/nodogsplash/description | |||
| endef | |||
|
|
|||
| define Package/nodogsplash/install | |||
| $(CP) ./files/* $(1)/ | |||
There was a problem hiding this comment.
Uhh, this is not good. The PR was draft and then it was merged.
I would like to avoid this. You can not use CP for all. The previous solution was better, not the best.
There was a problem hiding this comment.
So you want each file to be referenced?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a buffer overflow in case the query string is too long.
Maintainer: me
Compile tested: Nexx wt3020, ramips/mt7620
Run tested: save as compiled; tested internet blocked and unblocked after splash site click