cjdns: switch version to be APK compatible #1060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With a switch to APK, the version schema becomes a hard requirement and may not contain arbitrary letters. Remove the `v` and attach it only while downloading/building. Signed-off-by: Paul Spooren <mail@aparcar.org>
BKPepe
reviewed
Apr 7, 2024
| @@ -17,13 +17,13 @@ | |||
| include $(TOPDIR)/rules.mk | |||
|
|
|||
| PKG_NAME:=cjdns | |||
| PKG_VERSION:=v21.1 | |||
| PKG_VERSION:=21.1 | |||
| PKG_RELEASE:=5 | |||
There was a problem hiding this comment.
Isn't it more like r6 then?
There was a problem hiding this comment.
Could be, but still I think that adding r should be done via treewide commit
|
@aparcar thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maintainer: @wfleurant
Compile tested: mipsel_24kc
Run tested: -
Description
With a switch to APK, the version schema becomes a hard requirement and may not contain arbitrary letters. Remove the
vand attach it only while downloading/building.