Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cjdns: switch version to be APK compatible #1060

Merged
merged 1 commit into from
Apr 7, 2024

Conversation

aparcar
Copy link
Member

@aparcar aparcar commented Apr 7, 2024

Maintainer: @wfleurant
Compile tested: mipsel_24kc
Run tested: -

Description
With a switch to APK, the version schema becomes a hard requirement and may not contain arbitrary letters. Remove the v and attach it only while downloading/building.

With a switch to APK, the version schema becomes a hard requirement and
may not contain arbitrary letters. Remove the `v` and attach it only
while downloading/building.

Signed-off-by: Paul Spooren <mail@aparcar.org>
@@ -17,13 +17,13 @@
include $(TOPDIR)/rules.mk

PKG_NAME:=cjdns
PKG_VERSION:=v21.1
PKG_VERSION:=21.1
PKG_RELEASE:=5
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might want to reset it to 1

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't it more like r6 then?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could be, but still I think that adding r should be done via treewide commit

@wfleurant wfleurant merged commit c80474d into openwrt:master Apr 7, 2024
10 of 11 checks passed
@wfleurant
Copy link
Member

@aparcar thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants