Cleanup: Remove duplicate quantization checks #2566
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recent upstream change have introduced quantization checks that are
already present in the StableHLO core library. This commit removes these duplicate
checks to avoid redundancy and potential inconsistencies.
channel-axis >= 0
expressed_type
Note that StableHLO has checks like
quantization_dimension < rank(self)
anddim(self, quantization_dimension) = size(scales)
implemented at cs. In upstream MLIR similar checks cs are encoded as part of dcast and qcast ops and hence cannot be claimed as duplicate.related upstream clean-up llvm/llvm-project#110604