feat: pull recursively to include subject references #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tomas Coufal <tcoufal@redhat.com>
tumido
changed the title
Signed-off-by: Tomas Coufal <tcoufal@redhat.com>
tumido
force-pushed
the
pull-include-subject
branch
from
39f80ab
to
01732df
Compare
vsoch
reviewed
May 2, 2024
| @@ -489,6 +489,28 @@ def push(uri, root): | |||
|
|
|||
| </details> | |||
|
|
|||
| <details> | |||
|
|
|||
| <summary>Example of basic artifact attachment</summary> | |||
There was a problem hiding this comment.
This looks to be redundant with the other PR - let's do that one first, merge and rebase here, and then we can do the review.
There was a problem hiding this comment.
Yeah, I know... that's why I left this PR as a draft for now. 🙂 It builds on top of the other PR. I wanted to share the direction with you but wanted to keep PRs atomic at the same time. 🙂 Let's finish the first PR first and I'll rebase on top of it.
There was a problem hiding this comment.
Sounds good! Thank you for your work on both, and looking forward to coming back to this one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi folks 👋
I've noticed the Python Oras client library has kind of rudimentary support for attached artifacts. I'd like to address a couple of UX caveats in several PRs. Please let me know if it's heading in the right direction or if you have a different perspective.
Provide means to pull referred artifacts similar to
oras pull --include-subject:While
oras-pysupports including a subject when pushing a manifest, it does not support pulling the referenced artifact. I've inspired myself in theorasCLI, which has a--include-subjectflag. I've tried to inspire myself in theirpullimplementation as well however, this would require a quite substantial rewrite of theoras-pypull logic -orasCLI uses a graph approach to collect blobs to be pulled, whileoras-pysimply iterates through the layers list. Therefore I've resorted to a recursivepullcall based on the subject digest. This may raise some potential issues in the future since, well... it's recursion and it's synchronous. 🤷This PR depends on #131