-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support oras discover pass pagination args #1525
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: njucjc <njucjc@gmail.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1525 +/- ##
==========================================
- Coverage 85.59% 83.83% -1.76%
==========================================
Files 113 118 +5
Lines 3936 5173 +1237
==========================================
+ Hits 3369 4337 +968
- Misses 340 594 +254
- Partials 227 242 +15 ☔ View full report in Codecov by Sentry. |
Add @FeynmanZhou for UX-related discussion. |
@njucjc Could you create an issue for the motivation of this PR? Adding the page size option won't change the UX but may change the number of request send to the server as well as the expected server load. Note The pagination is not defined in the OCI distribution spec for the Referrers API. /cc @Wwwsylvia |
In other words, it depends entirely on the remote repository whether it implements the pagination defined by the ORAS artifact specification rather than the OCI distribution specification. |
@shizhMSFT OCI distribution specification already defined the the pagination |
@njucjc Not quite right. The OCI distribution spec defines how Note that the OCI distribution spec does define |
I've opened an issue on oras-go to track this issue: oras-project/oras-go#841 |
We also need to create an issue in the oras repo to elaborate on the feature request and why this is necessary for oras. |
What this PR does / why we need it:
support oras discover pass pagination args
Please check the following list: