Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

- folder name option added for DiskLogAdapter. #224

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

- folder name option added for DiskLogAdapter. #224

wants to merge 5 commits into from

Conversation

ummarbhutta
Copy link

  • max file size option added for DiskLogAdapter.
  • packages updated

@UmmarIqbal
- folder name option added for DiskLogAdapter.
acc524c 
- max file size option added for DiskLogAdapter.
- packages updated
Guiorgy
Guiorgy reviewed Feb 11, 2019
View reviewed changes
build.gradle Outdated Show resolved Hide resolved
Guiorgy
Guiorgy reviewed Feb 11, 2019
View reviewed changes
build.gradle Outdated Show resolved Hide resolved
@Guiorgy @ummarbhutta
Update build.gradle
9940d13 
Co-Authored-By: ummarbhutta <ummar_bhutta@yahoo.com>
Guiorgy
Guiorgy suggested changes Feb 11, 2019
View reviewed changes
logger/build.gradle Outdated Show resolved Hide resolved
sample/build.gradle Outdated Show resolved Hide resolved
Guiorgy and others added 3 commits February 11, 2019 15:57
@Guiorgy @ummarbhutta
Update build.gradle
59b1b41 
Co-Authored-By: ummarbhutta <ummar_bhutta@yahoo.com>
@Guiorgy @ummarbhutta
Update logger/build.gradle
990ac34 
Co-Authored-By: ummarbhutta <ummar_bhutta@yahoo.com>
@Guiorgy @ummarbhutta
Update sample/build.gradle
3ba5a36 
Co-Authored-By: ummarbhutta <ummar_bhutta@yahoo.com>
@Guiorgy
Copy link

Guiorgy commented Feb 11, 2019 •
edited
Loading

also, change buildToolsVersion = '27.0.3' to buildToolsVersion = '28.0.3' in logger/build.gradle (in the root folder)

@ummarbhutta
Copy link
Author

@Guiorgy The buildToolsVersion is already 28.0.3

@Guiorgy
Copy link

Guiorgy commented Feb 11, 2019 •
edited
Loading

@Guiorgy The buildToolsVersion is already 28.0.3

You replaced a global variable (rootProject.ext.buildToolsVersion) with a constant (28.0.3) in multiple files. I am just saying, that you should revert them back and change the variable value instead.

@ummarbhutta
Copy link
Author

Hello @Guiorgy

Thanks for suggestions and I accepted your suggestions and committed.

@nikitph
Copy link

nikitph commented Mar 8, 2021

can someone please merge this. we need this for a project

@lupaulus
Copy link

lupaulus commented Sep 16, 2021 •
edited
Loading

I forked and updated the project : Forked Project

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Guiorgy Guiorgy Guiorgy requested changes

@misha1528 misha1528 misha1528 approved these changes

@Hightower87 Hightower87 Hightower87 approved these changes

@rasoulmiri rasoulmiri rasoulmiri approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@ummarbhutta @Guiorgy @nikitph @lupaulus @rasoulmiri @Hightower87 @misha1528 @UmmarIqbal