find more cases (0 == ""), (0 == '0foo')

orklah · Jan 12, 2021 · 770b9b5 · 770b9b5
1 parent 71db6d0
commit 770b9b5
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/hooks/InsaneComparisonAnalyzer.php b/hooks/InsaneComparisonAnalyzer.php
@@ -105,7 +105,7 @@ public static function afterExpressionAnalysis(
         $eligible_string = null;
         foreach ($string_operand->getAtomicTypes() as $possibly_string) {
             if ($possibly_string instanceof TLiteralString) {
-                if(preg_match('#\D#', $possibly_string->value[0] ?? '')) {
+                if(!is_numeric($possibly_string->value)) {
                     $eligible_string = $possibly_string;
                     break;
                 }