Update cmake version used for the Frontier build script #4400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm. I kind of like the idea that we use the latest version and see/fix failures quickly when the version changes. So I'd probably vote for using the default. |
anagainaru
force-pushed
the
cmake-version
branch
from
5d77a25
to
80f2ff3
Compare
Ok, I set the default versions for all the scripts. Before we merge this, I want to check that we can build on all systems. I'll start with Frontier/Perlmutter but I am not sure if I still have access to Polaris/Summit. If I can't find anyone to test on those systems (assuming I don't have access) I'll remove the scripts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version
3.23.2is no longer available on FrontierI prefer spelling out the version (since we can guarantee that this combination will build succesfully), but I am also fine leaving the default versions if this is the preference (in which case we don't need a PR every time a version is no longer supported but users might get some unexpected errors).