New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bench workflow #343

Merged

orottier merged 2 commits into orottier:main from b-ma:fix/bench-workflow

Jul 20, 2023

Collaborator

b-ma commented Jul 20, 2023

ok that was not working properly... benches were triggered on every comment (so basically worse than the previous situation...)

So now

benchmark workflow should only run if comment is "/bench"
"post benchmark" is skipped if "benchmark" is not a success

Hopefully should be good now (these things are a real pain to test...)

b-ma added 2 commits

July 20, 2023 16:33


          fix: benchmark trigger

b2e8404


          fix: run only if benchmark was a success

7fb5fbc

orottier merged commit 76a8eb4 into orottier:main

3 checks passed

Owner

orottier commented Jul 21, 2023

Seems to be working now :)

b-ma deleted the fix/bench-workflow branch

November 4, 2023 06:42

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet