WPT fixes: channel splitter/merger error msg, offline ctx channel count mode #473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b-ma
reviewed
Mar 12, 2024
| @@ -74,7 +74,7 @@ impl AudioNode for AudioDestinationNode { | |||
| // OfflineAudioContext, then the channel count mode cannot be changed. | |||
| // An InvalidStateError exception MUST be thrown for any attempt to change the value. | |||
| assert!( | |||
| !self.registration.context().offline(), | |||
| !self.registration.context().offline() || v == ChannelCountMode::Explicit, | |||
There was a problem hiding this comment.
Cannot find where it is explained in the spec, maybe add something as comment ?
There was a problem hiding this comment.
Good point, added. I also found a spec issue related to the channelCount. Will double check and raise an issue at the spec repo
|
Apart my small comment, looks all good to me |
b-ma
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Big win with the AudioNode tests because of the fixed panic in the destination node