Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stack monitor that fails fast if transformer does not yield a sufficient stack number size. #101

Open
wants to merge 6 commits into
base: development
Choose a base branch
from

Conversation

raphw
Copy link
Collaborator

@raphw raphw commented Aug 26, 2024

To simplify debugging, each transformer's result should be validated to check if the created stack is equivalent with the requested result which should be an empty stack or a stack with size one. If the validation fails, one knows exactly which transformer did not create the expected result what should simplify locating the error.

Copy link

github-actions bot commented Aug 26, 2024

Test Results

 2 576 files  ±0   2 576 suites  ±0   13m 14s ⏱️ +46s
 6 305 tests ±0   6 220 ✅ ±0   85 💤 ±0  0 ❌ ±0 
25 392 runs  ±0  25 024 ✅ ±0  368 💤 ±0  0 ❌ ±0 

Results for commit 384e10c. ± Comparison against base commit 8416180.

♻️ This comment has been updated with latest results.

@bdw429s
Copy link
Contributor

bdw429s commented Sep 18, 2024

@jbeers Does this need merged?

@raphw
Copy link
Collaborator Author

raphw commented Sep 18, 2024

Just fixed the formatting, but I would recommend to add this to allow for debugging on a more local level.

@lmajano
Copy link
Contributor

lmajano commented Nov 19, 2024

Are we still going to add this, seems it has conflicts now?

# Conflicts:
#	src/main/java/ortus/boxlang/compiler/asmboxpiler/AsmTranspiler.java
@raphw
Copy link
Collaborator Author

raphw commented Nov 19, 2024

I think this could be valuable to have available if you suddenly encountered illegal byte code. It does not come with overhead, if deactivated, so I'd merge it in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants