test: proxy/tunnel with project id or slug

ory · Jul 4, 2023 · 07fc6f3 · 07fc6f3
1 parent 03cf464
commit 07fc6f3
Show file tree

Hide file tree

Showing 7 changed files with 256 additions and 117 deletions.
diff --git a/cmd/cloudx/client/handler.go b/cmd/cloudx/client/handler.go
@@ -86,8 +86,10 @@ type AuthProject struct {
 	Slug string    `json:"slug"`
 }
 
-var ErrNoConfig = stderrs.New("no ory configuration file present")
-var ErrNoConfigQuiet = stderrs.New("please run `ory auth` to initialize your configuration or remove the `--quiet` flag")
+var (
+	ErrNoConfig      = stderrs.New("no ory configuration file present")
+	ErrNoConfigQuiet = stderrs.New("please run `ory auth` to initialize your configuration or remove the `--quiet` flag")
+)
 
 func getConfigPath(cmd *cobra.Command) (string, error) {
 	path, err := os.UserHomeDir()
@@ -102,6 +104,10 @@ func getConfigPath(cmd *cobra.Command) (string, error) {
 	), nil
 }
 
+type Command interface {
+	GetProject(string) (*cloud.Project, error)
+}
+
 type CommandHelper struct {
 	Ctx              context.Context
 	VerboseWriter    io.Writer
@@ -114,6 +120,8 @@ type CommandHelper struct {
 	PwReader         passwordReader
 }
 
+var _ Command = new(CommandHelper)
+
 type PasswordReader struct{}
 
 // NewCommandHelper creates a new CommandHelper instance which handles cobra CLI commands.
@@ -123,12 +131,12 @@ func NewCommandHelper(cmd *cobra.Command) (*CommandHelper, error) {
 		return nil, err
 	}
 
-	var out = cmd.OutOrStdout()
+	out := cmd.OutOrStdout()
 	if flagx.MustGetBool(cmd, cmdx.FlagQuiet) {
 		out = io.Discard
 	}
 
-	var outErr = cmd.ErrOrStderr()
+	outErr := cmd.ErrOrStderr()
 	if flagx.MustGetBool(cmd, cmdx.FlagQuiet) {
 		outErr = io.Discard
 	}

diff --git a/cmd/cloudx/client/mock_handler.go b/cmd/cloudx/client/mock_handler.go
@@ -0,0 +1,16 @@
+// Copyright © 2023 Ory Corp
+// SPDX-License-Identifier: Apache-2.0
+
+package client
+
+import cloud "github.com/ory/client-go"
+
+type MockCommandHelper struct {
+	Project *cloud.Project
+}
+
+var _ Command = new(MockCommandHelper)
+
+func (n *MockCommandHelper) GetProject(projectId string) (*cloud.Project, error) {
+	return n.Project, nil
+}
diff --git a/cmd/cloudx/proxy/cmd_proxy.go b/cmd/cloudx/proxy/cmd_proxy.go
@@ -193,7 +193,9 @@ An example payload of the JSON Web Token is:
 				return err
 			}
 
-			oryURL, err := getEndpointURL(cmd)
+			projectSlugId := getProjectSlugId(cmd)
+
+			oryURL, err := getEndpointURL(cmd, projectSlugId)
 			if err != nil {
 				return err
 			}
@@ -205,23 +207,24 @@ An example payload of the JSON Web Token is:
 				return err
 			}
 
-			conf := &config{
-				port:              flagx.MustGetInt(cmd, PortFlag),
-				noJWT:             flagx.MustGetBool(cmd, WithoutJWTFlag),
-				noOpen:            !flagx.MustGetBool(cmd, OpenFlag),
-				upstream:          args[0],
-				cookieDomain:      flagx.MustGetString(cmd, CookieDomainFlag),
-				publicURL:         selfURL,
-				oryURL:            oryURL,
-				pathPrefix:        "/.ory",
-				defaultRedirectTo: redirectURL,
-				isDev:             flagx.MustGetBool(cmd, DevFlag),
-				isDebug:           flagx.MustGetBool(cmd, DebugFlag),
-				rewriteHost:       flagx.MustGetBool(cmd, RewriteHostFlag),
-				corsOrigins:       origins,
+			conf := &ProxyConfig{
+				Port:              flagx.MustGetInt(cmd, PortFlag),
+				NoJWT:             flagx.MustGetBool(cmd, WithoutJWTFlag),
+				NoOpen:            !flagx.MustGetBool(cmd, OpenFlag),
+				Upstream:          args[0],
+				CookieDomain:      flagx.MustGetString(cmd, CookieDomainFlag),
+				PublicURL:         selfURL,
+				OryURL:            oryURL,
+				PathPrefix:        "/.ory",
+				DefaultRedirectTo: redirectURL,
+				IsDev:             flagx.MustGetBool(cmd, DevFlag),
+				IsDebug:           flagx.MustGetBool(cmd, DebugFlag),
+				RewriteHost:       flagx.MustGetBool(cmd, RewriteHostFlag),
+				CorsOrigins:       origins,
+				ProjectSlugId:     projectSlugId,
 			}
 
-			return run(cmd, conf, version, "cloud")
+			return Run(cmd, conf, version, "cloud")
 		},
 	}
 
@@ -243,22 +246,31 @@ An example payload of the JSON Web Token is:
 	return proxyCmd
 }
 
-const envVarSlug = "ORY_PROJECT_SLUG"
-const envVarSDK = "ORY_SDK_URL"
-const envVarKratos = "ORY_KRATOS_URL"
+const (
+	envVarSlug   = "ORY_PROJECT_SLUG"
+	envVarSDK    = "ORY_SDK_URL"
+	envVarKratos = "ORY_KRATOS_URL"
+)
 
-func getEndpointURL(cmd *cobra.Command) (*url.URL, error) {
-	var target string
+func getProjectSlugId(cmd *cobra.Command) string {
 	if slug := os.Getenv(envVarSlug); len(slug) > 0 {
+		return slug
+	} else if slug := flagx.MustGetString(cmd, ProjectFlag); len(slug) > 0 {
+		return slug
+	}
+	return ""
+}
+
+func getEndpointURL(cmd *cobra.Command, slug string) (*url.URL, error) {
+	var target string
+	if slug != "" {
 		target = fmt.Sprintf("https://%s.projects.oryapis.com/", slug)
 	} else if url := stringsx.Coalesce(os.Getenv(envVarSDK), os.Getenv(envVarKratos)); len(url) > 0 {
 		target = url
-	} else if slug := flagx.MustGetString(cmd, ProjectFlag); len(slug) > 0 {
-		target = fmt.Sprintf("https://%s.projects.oryapis.com/", slug)
 	}
 
 	if len(target) == 0 {
-		return nil, errors.Errorf("Please provide your project slug using the --%s flag or the %s environment variable.", ProjectFlag, envVarSlug)
+		return nil, errors.Errorf("Please provide your project slug or project id using the --%s flag or the %s environment variable.", ProjectFlag, envVarSlug)
 	}
 
 	upstream, err := url.ParseRequestURI(target)

diff --git a/cmd/cloudx/proxy/cmd_proxy_test.go b/cmd/cloudx/proxy/cmd_proxy_test.go
@@ -21,14 +21,15 @@ func newEndpointCmd(def string) *cobra.Command {
 
 func TestGetEndpointURL(t *testing.T) {
 	t.Run("should fail if no project is set", func(t *testing.T) {
-		_, err := getEndpointURL(newEndpointCmd(""))
+		cmd := newEndpointCmd("")
+		_, err := getEndpointURL(cmd, getProjectSlugId(cmd))
 		require.Error(t, err)
 	})
 
 	t.Run("should return the right value from the flag", func(t *testing.T) {
 		expected := "someslug"
 		cmd := newEndpointCmd(expected)
-		actual, err := getEndpointURL(cmd)
+		actual, err := getEndpointURL(cmd, getProjectSlugId(cmd))
 		require.NoError(t, err)
 		assert.Equal(t, "https://"+expected+".projects.oryapis.com/", actual.String())
 	})
@@ -39,7 +40,7 @@ func TestGetEndpointURL(t *testing.T) {
 		t.Setenv(envVarSlug, expected)
 		cmd := newEndpointCmd("not-someslug")
 		cmd.SetErr(&b)
-		actual, err := getEndpointURL(cmd)
+		actual, err := getEndpointURL(cmd, getProjectSlugId(cmd))
 		require.Error(t, err)
 		assert.Nil(t, actual)
 		assert.Equal(t, "Attention! We found multiple sources for the project slug. Please clean up environment variables and flags to ensure that the correct value is being used. Found values:\n\n\t--project=not-someslug\n\tORY_PROJECT_SLUG=someslug\n\n", b.String())
@@ -51,7 +52,7 @@ func TestGetEndpointURL(t *testing.T) {
 		t.Setenv(envVarSDK, expected)
 		cmd := newEndpointCmd("not-someslug")
 		cmd.SetErr(&b)
-		_, err := getEndpointURL(cmd)
+		_, err := getEndpointURL(cmd, getProjectSlugId(cmd))
 		require.Error(t, err)
 	})
 }
diff --git a/cmd/cloudx/proxy/cmd_tunnel.go b/cmd/cloudx/proxy/cmd_tunnel.go
@@ -125,7 +125,9 @@ TO use a different default redirect URL, use the `+"`"+`--default-redirect-url`+
 				return err
 			}
 
-			oryURL, err := getEndpointURL(cmd)
+			projectSlugId := getProjectSlugId(cmd)
+
+			oryURL, err := getEndpointURL(cmd, projectSlugId)
 			if err != nil {
 				return err
 			}
@@ -142,23 +144,24 @@ TO use a different default redirect URL, use the `+"`"+`--default-redirect-url`+
 				return err
 			}
 
-			conf := &config{
-				port:              flagx.MustGetInt(cmd, PortFlag),
-				noJWT:             true,
-				noOpen:            true,
-				upstream:          oryURL.String(),
-				cookieDomain:      flagx.MustGetString(cmd, CookieDomainFlag),
-				publicURL:         selfURL,
-				oryURL:            oryURL,
-				pathPrefix:        "",
-				isTunnel:          true,
-				defaultRedirectTo: redirectURL,
-				isDev:             flagx.MustGetBool(cmd, DevFlag),
-				isDebug:           flagx.MustGetBool(cmd, DebugFlag),
-				corsOrigins:       origins,
+			conf := &ProxyConfig{
+				Port:              flagx.MustGetInt(cmd, PortFlag),
+				NoJWT:             true,
+				NoOpen:            true,
+				Upstream:          oryURL.String(),
+				CookieDomain:      flagx.MustGetString(cmd, CookieDomainFlag),
+				PublicURL:         selfURL,
+				OryURL:            oryURL,
+				PathPrefix:        "",
+				IsTunnel:          true,
+				DefaultRedirectTo: redirectURL,
+				IsDev:             flagx.MustGetBool(cmd, DevFlag),
+				IsDebug:           flagx.MustGetBool(cmd, DebugFlag),
+				CorsOrigins:       origins,
+				ProjectSlugId:     projectSlugId,
 			}
 
-			return run(cmd, conf, version, "cloud")
+			return Run(cmd, conf, version, "cloud")
 		},
 	}