Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [#754] Set the ID of the original requester early #755

Closed

Conversation

vivshankar
Copy link
Contributor

The description of the problem is part of the #754 . This is not a breaking change.

Related Issue or Design Document

N/A

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact security@ory.sh) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

This is a minor change that has no impact to existing flows. It merely serves to be consistent with the auth code flow implementation and caters for cases highlighted in the Github issue.

@vivshankar vivshankar requested a review from aeneasr as a code owner July 15, 2023 01:49
@vivshankar
Copy link
Contributor Author

Re-opening another PR.

@vivshankar vivshankar closed this Jul 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant