Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade Makefile controller-tools version to latest #146

Closed

Conversation

David-Wobrock
Copy link
Contributor

@David-Wobrock David-Wobrock commented Jun 22, 2024

Without this,

  • make generate and make test don't work locally with Go 1.22
  • the CI on master is failing

Relates to kubernetes-sigs/controller-tools#880 and kubernetes-sigs/controller-runtime#2720

Related Issue or Design Document

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact security@ory.sh) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

@David-Wobrock David-Wobrock changed the title Upgrade Makefile controller-tools version to latest. chore: upgrade Makefile controller-tools version to latest Jun 22, 2024
@David-Wobrock David-Wobrock force-pushed the chore/upgrade-dependencies branch 3 times, most recently from 8632ef3 to 5f3ecdc Compare June 23, 2024 11:10
@David-Wobrock David-Wobrock force-pushed the chore/upgrade-dependencies branch from 5f3ecdc to 57c2342 Compare June 23, 2024 11:13
@David-Wobrock
Copy link
Contributor Author

Dropped in favor of #145.

@David-Wobrock David-Wobrock deleted the chore/upgrade-dependencies branch June 23, 2024 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant