feat: template extraEnv #704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jagregory
force-pushed
the
template-extra-env
branch
from
e8011c0 to
6519179
Compare
|
Hi there! |
|
Will do, thanks Jakub!
…On Tue, 17 Sep 2024 at 5:10 pm, Jakub Błaszczyk ***@***.***> wrote:
Hi there!
I have nothing agains this feature, as it does not modify the default
behaviour, not is it a breaking change, but please add a few words to the
documentation of the components showing an example plus update at least one
of the values in hacks/values to have this option be checked in the CI :)
—
Reply to this email directly, view it on GitHub
<#704 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAACUTFFA5MJ2UAVVKXII63ZW7IYFAVCNFSM6AAAAABOKVX7JOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNJUG4ZDENZSGE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
jagregory
force-pushed
the
template-extra-env
branch
from
e0de99a to
579d64e
Compare
|
@Demonsthere FYI I've updated this PR and #703, let me know if you have any other feedback. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #703, it's useful to be able to template extra environment variables (especially
DSN). For example, when using several Ory components and multiple environments you can template the DSNs to a shared value instead of needing to set each individually.Checklist
If this pull request addresses a security vulnerability,
I confirm that I got approval (please contact security@ory.sh) from the maintainers to push the changes.