-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Trestle release #1399
Merged
chore: Trestle release #1399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: degenaro <lou.degenaro@gmail.com>
* feat(cli): adds logic to filter ssp by control origination Adds test to test one and multiple control origination value inputs Adds test to test bad control origintation value input Adds filtering logic to ssp.py Closes #1361 Signed-off-by: Jennifer Power <barnabei.jennifer@gmail.com> * docs: updates trestle author docs with ssp-filter changes for control origination Signed-off-by: Jennifer Power <barnabei.jennifer@gmail.com> * fix: updates control origination flag value in ssp.py Signed-off-by: Jennifer Power <barnabei.jennifer@gmail.com> * fix: adds break to remove duplicate implemented requirements When filtering for control origination, the property could be specified more than one time. This change adds a break and changes to the test component defintion to ensure this case is covered. Signed-off-by: Jennifer Power <barnabei.jennifer@gmail.com> --------- Signed-off-by: Jennifer Power <barnabei.jennifer@gmail.com>
…own (#1390) * fix: use empty string if part prose is None Signed-off-by: Sharma-Amit <Sharma.Amit@ibm.com> * test: add test for checking no prose in part Signed-off-by: Sharma-Amit <Sharma.Amit@ibm.com> --------- Signed-off-by: Sharma-Amit <Sharma.Amit@ibm.com> Co-authored-by: AleJo2995 <alejandro.leiva.palomo@ibm.com>
…on (#1395) * fix: use empty string if part prose is None Signed-off-by: Sharma-Amit <Sharma.Amit@ibm.com> * test: add test for checking no prose in part Signed-off-by: Sharma-Amit <Sharma.Amit@ibm.com> * fix: write warning instead of exit with code 1 when duplicate parts Signed-off-by: Sharma-Amit <Sharma.Amit@ibm.com> --------- Signed-off-by: Sharma-Amit <Sharma.Amit@ibm.com>
* feat: oscal-catalog-to-csv Signed-off-by: degenaro <lou.degenaro@gmail.com> * Populate testing spot checks. Signed-off-by: degenaro <lou.degenaro@gmail.com> * fix validate Signed-off-by: degenaro <lou.degenaro@gmail.com> * Use 'w' for output file open. Signed-off-by: degenaro <lou.degenaro@gmail.com> * fix windows csv. Signed-off-by: degenaro <lou.degenaro@gmail.com> * Fix sonar complaints + improved test coverage Signed-off-by: degenaro <lou.degenaro@gmail.com> * Fix sonar complaint. Signed-off-by: degenaro <lou.degenaro@gmail.com> * Improve test coverage. Signed-off-by: degenaro <lou.degenaro@gmail.com> * 100% test coverage. Signed-off-by: degenaro <lou.degenaro@gmail.com> --------- Signed-off-by: degenaro <lou.degenaro@gmail.com>
mrgadgil
approved these changes
Jun 16, 2023
@vikas-agarwal76 could you approve please? Manjiree seems to have lost admin access to approve |
* test: adds testdata for profile init tests Signed-off-by: Jennifer Power <barnabei.jennifer@gmail.com> * feat(cli): adds profile-seed command Adds profile-seed as author subcommand Adds profile-seed unit test Adds SSP testdata Closes #1388 Signed-off-by: Jennifer Power <barnabei.jennifer@gmail.com> * chore: updates flag wording in profile.py Signed-off-by: Jennifer Power <barnabei.jennifer@gmail.com> * test: adds test case for profile-seed Adds additional test case to check for ids output when all controls are filtered out Signed-off-by: Jennifer Power <barnabei.jennifer@gmail.com> * test: updates description leveraged ssp testdata Signed-off-by: Jennifer Power <barnabei.jennifer@gmail.com> * docs: updates author and tutorial docs with information on profile-seed command Signed-off-by: Jennifer Power <barnabei.jennifer@gmail.com> * chore: updates command to profile-inherit in docs and code Signed-off-by: Jennifer Power <barnabei.jennifer@gmail.com> * feat: adds excluded controls to the profile-inherit generated profile Signed-off-by: Jennifer Power <barnabei.jennifer@gmail.com> * docs: adds JSON example of profile-inherit import to website docs Signed-off-by: Jennifer Power <barnabei.jennifer@gmail.com> * chore: adds PR feedback on styling Signed-off-by: Jennifer Power <barnabei.jennifer@gmail.com> --------- Signed-off-by: Jennifer Power <barnabei.jennifer@gmail.com>
vikas-agarwal76
approved these changes
Jun 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* fix: python 3.7.17 issue Signed-off-by: Lou DeGenaro <lou.degenaro@gmail.com> * fix: python 3.7.17 issue Signed-off-by: Lou DeGenaro <lou.degenaro@gmail.com> --------- Signed-off-by: Lou DeGenaro <lou.degenaro@gmail.com>
Co-authored-by: AleJo2995 <alejandro.leiva.palomo@ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
develop
->main
)Quality assurance (all should be covered).
Summary
Bumping version from 2.1.1 to 2.2.0
Key links:
Before you merge