-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: pydantic 2.0.0 break unit tests #1418
Conversation
Signed-off-by: Lou DeGenaro <lou.degenaro@gmail.com>
Fixes #1416 |
setup.cfg
Outdated
@@ -32,7 +32,7 @@ install_requires = | |||
paramiko | |||
ruamel.yaml | |||
furl | |||
pydantic[email]>=1.8.2 | |||
pydantic[email]>1.8.1,<2.0.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@degenaro Make it -
pydantic[email]>=1.8.2,<2.0.0
This way the min. working version will be explicit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
Signed-off-by: Lou DeGenaro <lou.degenaro@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* fix: pydantic 2.0.0 break unit tests Signed-off-by: Lou DeGenaro <lou.degenaro@gmail.com> * fix minimum pydantic version Signed-off-by: Lou DeGenaro <lou.degenaro@gmail.com> --------- Signed-off-by: Lou DeGenaro <lou.degenaro@gmail.com> Co-authored-by: AleJo2995 <alejandro.leiva.palomo@ibm.com>
Types of changes
develop
->main
)Quality assurance (all should be covered).
Summary
Key links:
Before you merge