Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: extend multiple templates validation to trestle author folders #1430

Merged
merged 17 commits into from
Aug 24, 2023

Conversation

AleJo2995
Copy link
Collaborator

@AleJo2995 AleJo2995 commented Jul 27, 2023

Types of changes

  • Hot fix (emergency fix and release)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation (change which affects the documentation site)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Release (develop -> main)

Quality assurance (all should be covered).

  • My code follows the code style of this project.
  • Documentation for my change is up to date?
  • My PR meets testing requirements.
  • All new and existing tests passed.
  • All commits are signed-off.

Summary

Closes #1424

Key links:

Before you merge

  • Ensure it is a 'squash commit' if not a release.
  • Ensure CI is currently passing
  • Check sonar. If you are working for a fork a maintainer will reach out, if required.

…command

Signed-off-by: Alejandro Jose Leiva Palomo <alejandro.leiva.palomo@ibm.com>
Signed-off-by: Alejandro Jose Leiva Palomo <alejandro.leiva.palomo@ibm.com>
@AleJo2995 AleJo2995 changed the title feat: extend multiple templates validation to trestle author folders … feat: extend multiple templates validation to trestle author folders Jul 27, 2023
@AleJo2995
Copy link
Collaborator Author

@jayhawk87 here's the PR with the changes regarding #1424 . Please take a look and feel free to review it as wish and provide any feedback on it prior release :)

docs/trestle_author.md Show resolved Hide resolved
docs/trestle_author.md Show resolved Hide resolved
@AleJo2995
Copy link
Collaborator Author

@vikas-agarwal76 I have addressed your comments correspondingly. Can you please review again?

Signed-off-by: Alejandro Jose Leiva Palomo <alejandro.leiva.palomo@ibm.com>
Copy link
Collaborator

@vikas-agarwal76 vikas-agarwal76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Alejandro Jose Leiva Palomo <alejandro.leiva.palomo@ibm.com>
Signed-off-by: Alejandro Jose Leiva Palomo <alejandro.leiva.palomo@ibm.com>
Signed-off-by: Alejandro Jose Leiva Palomo <alejandro.leiva.palomo@ibm.com>
@AleJo2995
Copy link
Collaborator Author

@vikas-agarwal76 I have explore the options and now I understand. x-trestle-ignore is actually a field in the template that the user will explicitly define which fields in the instance don't need to be validated. In that way, we can set x-trestl-template-type field in the instance without having the mismatch. Look at the latest changes, review so I can proceed to merge :)

Signed-off-by: Alejandro Jose Leiva Palomo <alejandro.leiva.palomo@ibm.com>
Signed-off-by: Alejandro Jose Leiva Palomo <alejandro.leiva.palomo@ibm.com>
Signed-off-by: Alejandro Jose Leiva Palomo <alejandro.leiva.palomo@ibm.com>
@AleJo2995 AleJo2995 merged commit c7bef58 into develop Aug 24, 2023
16 checks passed
@AleJo2995 AleJo2995 deleted the feat/extend-multiple-templates branch August 24, 2023 15:19
@AleJo2995 AleJo2995 mentioned this pull request Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extend mixed template document processing
3 participants