-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: extend multiple templates validation to trestle author folders #1430
Conversation
…command Signed-off-by: Alejandro Jose Leiva Palomo <alejandro.leiva.palomo@ibm.com>
Signed-off-by: Alejandro Jose Leiva Palomo <alejandro.leiva.palomo@ibm.com>
…BM/compliance-trestle into feat/extend-multiple-templates
@jayhawk87 here's the PR with the changes regarding #1424 . Please take a look and feel free to review it as wish and provide any feedback on it prior release :) |
…ield Signed-off-by: Alejandro Jose Leiva Palomo <alejandro.leiva.palomo@ibm.com>
@vikas-agarwal76 I have addressed your comments correspondingly. Can you please review again? |
tests/data/author/governed_folders/template_folder_with_template_type/architecture.md
Show resolved
Hide resolved
tests/data/author/governed_folders/template_folder_with_template_type/network.md
Show resolved
Hide resolved
Signed-off-by: Alejandro Jose Leiva Palomo <alejandro.leiva.palomo@ibm.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Alejandro Jose Leiva Palomo <alejandro.leiva.palomo@ibm.com>
Signed-off-by: Alejandro Jose Leiva Palomo <alejandro.leiva.palomo@ibm.com>
Signed-off-by: Alejandro Jose Leiva Palomo <alejandro.leiva.palomo@ibm.com>
@vikas-agarwal76 I have explore the options and now I understand. |
Signed-off-by: Alejandro Jose Leiva Palomo <alejandro.leiva.palomo@ibm.com>
Signed-off-by: Alejandro Jose Leiva Palomo <alejandro.leiva.palomo@ibm.com>
…BM/compliance-trestle into feat/extend-multiple-templates
Signed-off-by: Alejandro Jose Leiva Palomo <alejandro.leiva.palomo@ibm.com>
Types of changes
develop
->main
)Quality assurance (all should be covered).
Summary
Closes #1424
Key links:
Before you merge