feat: support validation component_type for task csv-to-oscal-cd #1431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lou DeGenaro <lou.degenaro@gmail.com>
degenaro
changed the title
Signed-off-by: Lou DeGenaro <lou.degenaro@gmail.com>
Signed-off-by: Lou DeGenaro <lou.degenaro@gmail.com>
vikas-agarwal76
requested changes
Aug 7, 2023
| for column_name in column_names: | ||
| prop_name = self._get_prop_name(column_name) | ||
| prop_value = self._csv_mgr.get_value(rule_key, column_name).strip() | ||
| rule_set_mgr.add_prop(prop_name, prop_value, namespace, self.get_class(prop_name)) | ||
| return rule_set_mgr.get_props() |
There was a problem hiding this comment.
@degenaro Are user columns only getting added for non-validation component? I believe it should be added for all components.
Signed-off-by: Lou DeGenaro <lou.degenaro@gmail.com>
jpower432
pushed a commit
to jpower432/compliance-trestle
that referenced
this pull request
Aug 23, 2023
…al-compass#1431) * feat: Support "validation" component_type for task csv-to-oscal-cd Signed-off-by: Lou DeGenaro <lou.degenaro@gmail.com> * fix sonar code smell Signed-off-by: Lou DeGenaro <lou.degenaro@gmail.com> * add notes to -i output regarding required/ignored columns Signed-off-by: Lou DeGenaro <lou.degenaro@gmail.com> * user properties for both validation and non-validation components Signed-off-by: Lou DeGenaro <lou.degenaro@gmail.com> --------- Signed-off-by: Lou DeGenaro <lou.degenaro@gmail.com> Co-authored-by: AleJo2995 <alejandro.leiva.palomo@ibm.com>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
develop->main)Quality assurance (all should be covered).
Summary
Key links:
Before you merge