Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: adds typing fixes in profile.py for ProfileInherit #1433

Merged
merged 5 commits into from
Aug 22, 2023
Merged

chore: adds typing fixes in profile.py for ProfileInherit #1433

merged 5 commits into from
Aug 22, 2023

Conversation

jpower432
Copy link
Member

Types of changes

  • Hot fix (emergency fix and release)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation (change which affects the documentation site)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Release (develop -> main)

Quality assurance (all should be covered).

  • My code follows the code style of this project.
  • Documentation for my change is up to date?
  • My PR meets testing requirements.
  • All new and existing tests passed.
  • All commits are signed-off.

Summary

Not strictly a bug, but fixes some typing issues found with mypy in profile-inherit.

Related to #1392

Key links:

Before you merge

  • Ensure it is a 'squash commit' if not a release.
  • Ensure CI is currently passing
  • Check sonar. If you are working for a fork a maintainer will reach out, if required.

@jpower432 jpower432 marked this pull request as ready for review August 8, 2023 22:18
vikas-agarwal76
vikas-agarwal76 approved these changes Aug 16, 2023
View reviewed changes
Copy link
Collaborator

@vikas-agarwal76 vikas-agarwal76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jpower432 jpower432 enabled auto-merge (squash) August 22, 2023 14:29
@jpower432 jpower432 merged commit 0593651 into develop Aug 22, 2023
15 checks passed
@jpower432 jpower432 deleted the chore/mypy-fixes-profile-inherit branch August 22, 2023 14:40
jpower432 added a commit to jpower432/compliance-trestle that referenced this pull request Aug 23, 2023
@jpower432 @AleJo2995
chore: adds typing fixes in profile.py for ProfileInherit (oscal-comp…
7c591a1 
…ass#1433)

Signed-off-by: Jennifer Power <barnabei.jennifer@gmail.com>
Co-authored-by: AleJo2995 <alejandro.leiva.palomo@ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vikas-agarwal76 vikas-agarwal76 vikas-agarwal76 approved these changes

@AleJo2995 AleJo2995 Awaiting requested review from AleJo2995

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jpower432 @vikas-agarwal76 @AleJo2995