Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: headings levels validation is not working properly #1436

Merged
merged 4 commits into from
Aug 15, 2023
Merged

fix: headings levels validation is not working properly #1436

merged 4 commits into from
Aug 15, 2023

Conversation

AleJo2995
Copy link
Collaborator

Types of changes

  • Hot fix (emergency fix and release)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation (change which affects the documentation site)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Release (develop -> main)

Quality assurance (all should be covered).

  • My code follows the code style of this project.
  • Documentation for my change is up to date?
  • My PR meets testing requirements.
  • All new and existing tests passed.
  • All commits are signed-off.

Summary

Closes #1429

Key links:

Before you merge

  • Ensure it is a 'squash commit' if not a release.
  • Ensure CI is currently passing
  • Check sonar. If you are working for a fork a maintainer will reach out, if required.

@AleJo2995
fix: heading levels validation fixing
e126437 
Signed-off-by: Alejandro Jose Leiva Palomo <alejandro.leiva.palomo@ibm.com>
@AleJo2995
Merge branch 'develop' into fix/heading-levels-val
85c88e9
@AleJo2995
fix: correcting test cases and adding extra validation
d03f6d5 
Signed-off-by: Alejandro Jose Leiva Palomo <alejandro.leiva.palomo@ibm.com>
@AleJo2995 AleJo2995 marked this pull request as ready for review August 10, 2023 01:46
vikas-agarwal76
vikas-agarwal76 approved these changes Aug 11, 2023
View reviewed changes
Copy link
Collaborator

@vikas-agarwal76 vikas-agarwal76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AleJo2995 AleJo2995 merged commit 22b65a9 into develop Aug 15, 2023
16 checks passed
@AleJo2995 AleJo2995 deleted the fix/heading-levels-val branch August 15, 2023 13:38
jpower432 pushed a commit to jpower432/compliance-trestle that referenced this pull request Aug 23, 2023
@AleJo2995 @jpower432
fix: headings levels validation is not working properly (oscal-compas…
768a07a 
…s#1436)

* fix: heading levels validation fixing

Signed-off-by: Alejandro Jose Leiva Palomo <alejandro.leiva.palomo@ibm.com>

* fix: correcting test cases and adding extra validation

Signed-off-by: Alejandro Jose Leiva Palomo <alejandro.leiva.palomo@ibm.com>

---------

Signed-off-by: Alejandro Jose Leiva Palomo <alejandro.leiva.palomo@ibm.com>
@AleJo2995 AleJo2995 mentioned this pull request Sep 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vikas-agarwal76 vikas-agarwal76 vikas-agarwal76 approved these changes

@mrgadgil mrgadgil Awaiting requested review from mrgadgil

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Headings levels validation is not working properly
2 participants
@AleJo2995 @vikas-agarwal76