Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fixing typo in encoding name #1448

Merged
merged 2 commits into from
Sep 14, 2023
Merged

fix: fixing typo in encoding name #1448

merged 2 commits into from
Sep 14, 2023

Conversation

BE-Code
Copy link
Contributor

@BE-Code BE-Code commented Sep 6, 2023

Types of changes

  • Hot fix (emergency fix and release)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation (change which affects the documentation site)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Release (develop -> main)

Quality assurance (all should be covered).

  • My code follows the code style of this project.
  • Documentation for my change is up to date?
  • My PR meets testing requirements.
  • All new and existing tests passed.
  • All commits are signed-off.

Summary

Key links:

Before you merge

  • Ensure it is a 'squash commit' if not a release.
  • Ensure CI is currently passing
  • Check sonar. If you are working for a fork a maintainer will reach out, if required.

@AleJo2995 AleJo2995 changed the title Fix typo in encoding name fix: fixing typo in encoding name Sep 12, 2023
@AleJo2995 AleJo2995 self-requested a review September 14, 2023 15:15
@AleJo2995
Copy link
Collaborator

LGTM

@AleJo2995 AleJo2995 enabled auto-merge (squash) September 14, 2023 15:17
AleJo2995
AleJo2995 approved these changes Sep 14, 2023
View reviewed changes
Copy link
Collaborator

@AleJo2995 AleJo2995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AleJo2995 AleJo2995 merged commit bdf60b2 into oscal-compass:develop Sep 14, 2023
16 checks passed
jpower432 pushed a commit to RedHatProductSecurity/compliance-trestle that referenced this pull request Sep 18, 2023
@BE-Code @AleJo2995 @jpower432
fix: fixing typo in encoding name (oscal-compass#1448)
71d9539 
Co-authored-by: AleJo2995 <alejandro.leiva.palomo@ibm.com>
jpower432 pushed a commit to jpower432/compliance-trestle that referenced this pull request Sep 19, 2023
@BE-Code @AleJo2995 @jpower432
fix: fixing typo in encoding name (oscal-compass#1448)
2bc9f20 
Co-authored-by: AleJo2995 <alejandro.leiva.palomo@ibm.com>
@AleJo2995 AleJo2995 mentioned this pull request Sep 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AleJo2995 AleJo2995 AleJo2995 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BE-Code @AleJo2995