-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: make status and mitre column optional #1649
Conversation
Signed-off-by: Lou DeGenaro <lou.degenaro@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@degenaro I might be wrong but is there a particular reason for creating 3 different test cases with almost the same steps being executed inside? I think we could reuse the code and just create a function called test_cis_xlsx_to_oscal_catalog_wo_columns
or something similar and looping over the column values
Thx for the comment. Keeping test cases separate makes them simple and clear. These test cases are provided to insure 100% coverage for the subject under test. There is no real advantage to rolling up into a single test case in terms of time, space or duplication. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Types of changes
develop
->main
)Quality assurance (all should be covered).
Summary
Key links:
Before you merge