Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make status and mitre column optional #1649

Merged
merged 4 commits into from
Aug 9, 2024
Merged

Conversation

degenaro
Copy link
Collaborator

@degenaro degenaro commented Aug 8, 2024

Types of changes

  • Hot fix (emergency fix and release)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation (change which affects the documentation site)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Release (develop -> main)

Quality assurance (all should be covered).

  • My code follows the code style of this project.
  • Documentation for my change is up to date?
  • My PR meets testing requirements.
  • All new and existing tests passed.
  • All commits are signed-off.

Summary

Key links:

Before you merge

  • Ensure it is a 'squash commit' if not a release.
  • Ensure CI is currently passing
  • Check sonar. If you are working for a fork a maintainer will reach out, if required.

@degenaro degenaro changed the title fix - make status and mitre column optional fix: make status and mitre column optional Aug 8, 2024
@degenaro degenaro self-assigned this Aug 8, 2024
@degenaro degenaro added the bug Something isn't working label Aug 8, 2024
Copy link
Collaborator

@AleJo2995 AleJo2995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@degenaro I might be wrong but is there a particular reason for creating 3 different test cases with almost the same steps being executed inside? I think we could reuse the code and just create a function called test_cis_xlsx_to_oscal_catalog_wo_columns or something similar and looping over the column values

@degenaro
Copy link
Collaborator Author

degenaro commented Aug 9, 2024

@degenaro I might be wrong but is there a particular reason for creating 3 different test cases with almost the same steps being executed inside? I think we could reuse the code and just create a function called test_cis_xlsx_to_oscal_catalog_wo_columns or something similar and looping over the column values

Thx for the comment. Keeping test cases separate makes them simple and clear. These test cases are provided to insure 100% coverage for the subject under test. There is no real advantage to rolling up into a single test case in terms of time, space or duplication.

@degenaro degenaro requested a review from AleJo2995 August 9, 2024 15:56
Copy link
Member

@jpower432 jpower432 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@AleJo2995 AleJo2995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@degenaro degenaro merged commit 47e6936 into develop Aug 9, 2024
13 checks passed
@degenaro degenaro deleted the fix/cis-transformer branch August 9, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

trestle task cis-xlsx-to-oscal-catalog excessively requires columns
3 participants