Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add parameter aggregation support for SSP #1668

Merged
merged 2 commits into from
Aug 23, 2024

Conversation

AleJo2995
Copy link
Collaborator

Types of changes

  • Hot fix (emergency fix and release)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation (change which affects the documentation site)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Release (develop -> main)

Quality assurance (all should be covered).

  • My code follows the code style of this project.
  • Documentation for my change is up to date?
  • My PR meets testing requirements.
  • All new and existing tests passed.
  • All commits are signed-off.

Summary

Closes #1596

I'm making this as a feature addition as we didn't initially considered this to be supported in SSP, just in profile.

Key links:

Before you merge

  • Ensure it is a 'squash commit' if not a release.
  • Ensure CI is currently passing
  • Check sonar. If you are working for a fork a maintainer will reach out, if required.

Signed-off-by: Alejandro Jose Leiva Palomo <alejandro.leiva.palomo@ibm.com>
@AleJo2995 AleJo2995 self-assigned this Aug 22, 2024
@AleJo2995 AleJo2995 added this to the v3.4.0 milestone Aug 22, 2024
@AleJo2995
Copy link
Collaborator Author

@vikas-agarwal76 could you confirm this as feature? I'm making this as a feature addition as we didn't initially considered this to be supported in SSP, just in profile.

Copy link
Collaborator

@vikas-agarwal76 vikas-agarwal76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@rahearn rahearn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this branch out a bit this morning and it's working the way I expected. Thank you!

@AleJo2995 AleJo2995 merged commit b2611d1 into develop Aug 23, 2024
15 checks passed
@AleJo2995 AleJo2995 deleted the fix/ssp-generate-aggregates branch August 23, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

trestle author ssp-generate does not seem to do the correct thing with aggregates parameters
3 participants