remove permutation matrix function

oscar-system · Nov 1, 2024 · f8a4532 · f8a4532
1 parent 4ebc610
commit f8a4532
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 8 deletions.
diff --git a/experimental/AlgebraicShifting/src/PartialShift.jl b/experimental/AlgebraicShifting/src/PartialShift.jl
@@ -166,7 +166,11 @@ end
 
 compound_matrix(m::MatElem, k::Int) = compound_matrix(m, uniform_hypergraph(sort(subsets(size(m, 1), k))))
 compound_matrix(p::PermGroupElem, k::Int) = compound_matrix(permutation_matrix(ZZ, p), k)
-compound_matrix(w::WeylGroupElem, k::Int) = compound_matrix(permutation_matrix(ZZ, w), k)
+
+function compound_matrix(w::WeylGroupElem, k::Int)
+  iso = isomorphism(PermGroup, parent(w))
+  return compound_matrix(permutation_matrix(ZZ, iso(w)), k)
+end
 
 # this might be removed (currently is not used)
 function _set_to_zero(K::SimplicialComplex, indices::Tuple{Int, Int})

diff --git a/experimental/LieAlgebras/src/WeylGroup.jl b/experimental/LieAlgebras/src/WeylGroup.jl
@@ -733,10 +733,3 @@ function Base.iterate(iter::WeylOrbitIterator, state::WeylIteratorNoCopyState)
   (wt, _), state = it
   return deepcopy(wt), state
 end
-
-################################################################################
-# converting to permutation matrices
-
-function permutation_matrix(R::Ring, w::WeylGroupElem)
-  permutation_matrix(R, isomorphism(PermGroup, parent(w))(w))
-end