-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Iteratorify some tableaux #3887
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3887 +/- ##
=======================================
Coverage 83.87% 83.87%
=======================================
Files 589 589
Lines 80864 80940 +76
=======================================
+ Hits 67823 67892 +69
- Misses 13041 13048 +7
|
The doc for YTs mentions that the tableaux entries are "usually" (positive) integers in the range
What do you think about these suggestions? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
I copied the open questions to #3850. |
Turn
semistandard_tableaux(shape)
andstandard_tableaux
into an actual iterator internally.Also adds tests/fixes for different
Integer
types.ZZRingElem
doesn't work in general because the entries are often used as indices.The only function left, which still first fills an array internally and then iterates the entries, is
semistandard_tableaux(shape, weight)
.This function is unfortunately implemented recursively, so it would need to be reimplemented completely. There is no reference for the used algorithm given; I assume it was implemented by a Bachelor's student in JuLie originally. @ulthiel Is there a reference for this algorithm?