Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

修复迷你键盘不自动收起的问题;尝试修复悬浮窗问题;优化一点代码 #1127

Merged
merged 1 commit into from
Dec 4, 2023

Conversation

cabins
Copy link
Contributor

@cabins cabins commented Nov 30, 2023

Pull request

Issue tracker

Fixes will automatically close the related issues

Fixes #1126

Feature

  • 修复迷你键盘不自动收起的问题,原因xml中一个key写错了;
  • 尝试修复悬浮窗问题(需要更多人进行测试一下);
  • 优化一点代码(没有改逻辑,优化了一下之前一位大佬的写法)

Code of conduct

Style lint

  • make sytle-lint

Build pass

  • make debug

Manually test

  • Done

Code Review

  1. No wildcards import
  2. Manual build and test pass
  3. GitHub action ci pass
  4. At least one contributor reviews and votes
  5. Can be merged clean without conflicts
  6. PR will be merged by rebase upstream base

Daily build

Login and download artifact at https://github.com/osfans/trime/actions

Additional Info

@Bambooin
Copy link
Collaborator

Trigger the CI build manually, so others can download and verify this fix.

CI is failed due to spotless check: Run ./gradlew :spotlessApply to fix these violations.

It's nice to use the commit message template such as:

  • fix: fix float window size limit
  • fix: fix mini keyboard auto hiding

Thanks for your hard work to fix the issue and debug: #930

@Bambooin
Copy link
Collaborator

If you have time, please squash or rebase your commits to two parts:

  • fix: fix float window size limit
  • fix: fix mini keyboard auto hiding

If you don't have free time, it's ok right now, waiting for code review.

@tao659
Copy link

tao659 commented Nov 30, 2023

Screenshot_2023-12-01-06-17-45-459_com miui notes-edit
显示异常如图所示。

fix: fix mini keyboard auto hiding
@cabins
Copy link
Contributor Author

cabins commented Dec 1, 2023

Screenshot_2023-12-01-06-17-45-459_com miui notes-edit 显示异常如图所示。

Emmm……这就是我担心的适配问题。因为我手里只有vivo的设备,所以我测试了手机(Origin OS 4 based on Android 14)以及vivo Pad Air(Origin OS 3 based on Android 13)。看样子,这里真的是有适配问题。

待进一步排查。

@cabins
Copy link
Contributor Author

cabins commented Dec 1, 2023

If you have time, please squash or rebase your commits to two parts:

* fix: fix float window size limit

* fix: fix mini keyboard auto hiding

If you don't have free time, it's ok right now, waiting for code review.

Thank you so much for all recent guidances. I learned so much about debugging, creating pr, git-using and code style.

Proud of all trime contributors.

@Bambooin Bambooin merged commit 5dde264 into osfans:develop Dec 4, 2023
@cabins cabins deleted the cabins_debug branch December 5, 2023 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

关于悬浮窗,希望能有更多的人进行测试一下
3 participants