Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup and fix 20241211 #1530

Merged
merged 9 commits into from
Dec 13, 2024
Merged

Cleanup and fix 20241211 #1530

merged 9 commits into from
Dec 13, 2024

Conversation

WhiredPlanck
Copy link
Collaborator

@WhiredPlanck WhiredPlanck commented Dec 12, 2024 •
edited
Loading

Pull request

Issue tracker

Fixes will automatically close the related issues

Fixes # N/A

Feature

Describe features of this pull request

This PR is to clean up the code with small fixes, including:

  1. Clean up the code in util, especially ShorcutUtils.kt and Utils.kt.
  2. Remove unused string, layout and drawable, etc. resource.
  3. Refactor the build process, developers are able to trigger run on emulator or physical device directly without setting environment variable or gradle property.
  4. Tweak the preference screen to improve user experience.
  5. Tweak the preedit view when candidate window is disabled.

Code of conduct

Code style

Build pass

  • make debug

Manually test

  • Done

Code Review

  1. No wildcards import
  2. Manual build and test pass
  3. GitHub Action CI pass
  4. At least one contributor review and approve
  5. Merged clean without conflicts
  6. PR will be merged by rebase upstream base

Daily build

Login and download artifact at https://github.com/osfans/trime/actions

Additional Info

@WhiredPlanck WhiredPlanck force-pushed the cleanup-and-fix-20241211 branch from e7e3fc2 to cfa1c24 Compare December 13, 2024 10:48
Bambooin
Bambooin requested changes Dec 13, 2024
View reviewed changes
Copy link
Collaborator

@Bambooin Bambooin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please help to rename the typo of Datetime.kt to DateTime.kt.

@WhiredPlanck
refactor: split Utils.kt by function or receiver type
24b8bbe
@WhiredPlanck
refactor: slightly refine NinePatchBitmapFactory.kt
06f6f02
@WhiredPlanck
refactor: remove unused resources
9771f56
@WhiredPlanck
build: refactor build process
c23ba65 
- Allow developers to trigger run of application on emulator directly instead of setting target ABI first
@WhiredPlanck
refactor: bundle core native lib version name into BuildConfig
70b6f13
@WhiredPlanck
refactor: improve user experience of settings pages
d1095f5
@WhiredPlanck
refactor: correct preedit view behavior and polish its appearance
3bdd6cf 
- Fix the view wouldn't disappear after changing theme or color on site
- Allow to custom its background color
- Add top left corner radius
- Improve its visual effect of showup
- Get alpha value as float
@WhiredPlanck
Copy link
Collaborator Author

Please help to rename the typo of Datetime.kt to DateTime.kt.

Done.

@WhiredPlanck WhiredPlanck force-pushed the cleanup-and-fix-20241211 branch from cfa1c24 to 3bdd6cf Compare December 13, 2024 12:26
@WhiredPlanck WhiredPlanck merged commit 793b121 into osfans:develop Dec 13, 2024
3 checks passed
@WhiredPlanck WhiredPlanck deleted the cleanup-and-fix-20241211 branch December 13, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bambooin Bambooin Bambooin approved these changes

@goofyz goofyz Awaiting requested review from goofyz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WhiredPlanck @Bambooin