Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Check if the .makim.yaml file is valid according to the schema file #122

Merged
merged 3 commits into from
Oct 17, 2024

Conversation

xmnlab
Copy link
Member

@xmnlab xmnlab commented Oct 17, 2024

Pull Request description

How to test these changes

  • ...

Pull Request checklists

This PR is a:

  • bug-fix
  • new feature
  • maintenance

About this PR:

  • it includes tests.
  • the tests are executed on CI.
  • the tests generate log file(s) (path).
  • pre-commit hooks were executed locally.
  • this PR requires a project documentation update.

Author's checklist:

  • I have reviewed the changes and it contains no misspelling.
  • The code is well commented, especially in the parts that contain more
    complexity.
  • New and old tests passed locally.

Additional information

Reviewer's checklist

Copy and paste this template for your review's note:

## Reviewer's Checklist

- [ ] I managed to reproduce the problem locally from the `main` branch
- [ ] I managed to test the new changes locally
- [ ] I confirm that the issues mentioned were fixed/resolved .

@xmnlab xmnlab changed the title feat: Check if the .makim.yaml file is valid according to the schema … feat: Check if the .makim.yaml file is valid according to the schema file Oct 17, 2024
@xmnlab xmnlab merged commit 29d0b51 into osl-incubator:main Oct 17, 2024
12 checks passed
@xmnlab xmnlab deleted the check-config-with-schema branch October 17, 2024 02:28
@xmnlab
Copy link
Member Author

xmnlab commented Oct 17, 2024

@abhijeetSaroha , please take a look into this PR, you will need to implement your new changes to the schema.json as well

Copy link

🎉 This PR is included in version 1.19.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant