filter_pagelinks.py counts in memory, pagelinks tables obsolete #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #41
follow-up to #69
Instead of sorting the output
filter_pagelinks.pyand summarizing the counts after the sort, now the script sorts in-memory. For English wikipedia page this 3.8 GB memory, still reasonable these days.The
${lang}pagelinkcounttables are no longer needed. Saves about 10GB database size (103 -> 88GB). Also the CSV files are smaller: 294m rows for all languages before, now 174m (-40%).Overall time taken about the same.