Add license handling for NONMEM #7
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
do you mind pushing this in the initial PR, I think we'll need to go this direction for now, at least until we can dialog more with bob to figure out possible nonmem licensing options |
|
(just in case you didn't know, or anyone else reading) just push to your original branch billdenney:psn_4.7.0 on your end and github will automatically pick up the changes and update the PR |
|
Combined with #6; closed here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In combination with #6, this completes the fix for #3.
This PR includes the addition of a NONMEM license string to the container build. It is not as restrictive as #6 because it doesn't require the tests to be run-- it just enables them if possible.