Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Adjust the query to keep the destination rather than replace" #1014

Merged
merged 3 commits into from
Feb 16, 2024
Merged

Revert "Adjust the query to keep the destination rather than replace" #1014

merged 3 commits into from
Feb 16, 2024

Conversation

calebbrown
Copy link
Contributor

Reverts #1013

This reverts commit 836a6a2.

TRUNCATE + INSERT failed, so reverting back to the CREATE OR REPLACE

#1000

@maxfisher-g
Copy link
Contributor

Is there some way of manually checking whether the schema is different, and exiting if it is?

@calebbrown
Copy link
Contributor Author

Is there some way of manually checking whether the schema is different, and exiting if it is?

PTAL. I've added a check that aborts if the schemas are not identical.

@maxfisher-g
Copy link
Contributor

Nice, thanks Caleb!

@calebbrown calebbrown merged commit ec812cd into main Feb 16, 2024
13 checks passed
@calebbrown calebbrown deleted the rollback_bq_query branch February 16, 2024 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxfisher-g maxfisher-g maxfisher-g approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@calebbrown @maxfisher-g