Skip to content
This repository has been archived by the owner on Apr 18, 2024. It is now read-only.

WIP rewrite for Craft 4 #69

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

WIP rewrite for Craft 4 #69

wants to merge 3 commits into from

Conversation

ostark
Copy link
Owner

@ostark ostark commented Jul 12, 2022 •
edited
Loading

Discussions #68 & #65
Issue #67

So far no significant code changes, just structural.

  • Prepare for tests with pest
  • Use Handler classes instead of closures
  • Use DI Container instead of Service Locator (not everywhere so far)
  • Move event listener setup to the main Plugin class (remove EventRegistrar)
  • Refactor drivers (using https://github.com/Sammyjo20/Saloon)

@ostark ostark changed the title Craft 4 rewrite WIP rewrite for Craft 4 Jul 12, 2022
@mattbloomfield
Copy link

Hey @ostark any progress here?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ostark @mattbloomfield