Initial pass at making connectors easier to use on Linux #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 Is there a reason that this hasn't been accepted? |
|
Speaking with the developers, there was a concern that moving the paths to a variable added an extra step on Windows, thus making more work for potentially more users |
|
The hard coded path is going to be is issue for anyone who has IIB installed on a D drive, or in C:\IBM, or C:/Program Files/IBM/MQSI/9.0.0.1, or … This isn't just a Linux issue. |
Conflicts: README.md src/MQTTNodes/src/MQTTInputNodeUDN.java src/MQTTNodes/src/MQTTOutputNodeUDN.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using Eclipse variables means the path isn't hardcoded in the filesystem, making source control easier.
Can't see a reason to leave the invalid Package Comibm lines in source control either