Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "fix double libs loading (#4855)" #4859

Merged
1 commit merged into from
Nov 25, 2024

Conversation

ArturKnopik
Copy link
Contributor

This reverts commit 6f05ea8.

Pull Request Prelude

Changes Proposed

Issues addressed:
Revert comit related to double global.lua loading
Npc.h has own scriptInterface that require data from global.lua

std::shared_ptr<NpcScriptInterface> scriptInterface;

How to test:
N/A

@ArturKnopik
Copy link
Contributor Author

i not sure but on windows everything works fine, on linux things go crazy

@ghost ghost merged commit ccfd367 into otland:master Nov 25, 2024
16 checks passed
@ArturKnopik ArturKnopik deleted the revert_npcGlobalLua branch December 6, 2024 01:55
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant